Skip to content

fix: Improve test reliability#984

Open
Tranquility2 wants to merge 3 commits intomainfrom
fix/improve_core_testing
Open

fix: Improve test reliability#984
Tranquility2 wants to merge 3 commits intomainfrom
fix/improve_core_testing

Conversation

@Tranquility2
Copy link
Contributor

@Tranquility2 Tranquility2 commented Mar 16, 2026 •
edited
Loading

This was originally only to fix #983 but I took the time to fix some other stuff that made reading and running the tests less optimal.

  • Fix test_ryuk flakiness: replace fixed sleep with polling helper (_wait_for_container_removed) that waits for Ryuk to finish reaping
  • Suppress expected error logs in test_compose_volumes and test_wait_strategies to reduce test noise
  • Add test = False to TestcontainersConfiguration to prevent pytest from trying to collect it as a test class
  • Add long_running pytest marker to pyproject.toml
  • Mark DinD/DooD tests as long_running since they build Docker images and take x4 than all the other tests combined
  • Add quick-core-tests Makefile target to run core tests excluding long_running tests for faster feedback loops

@Tranquility2 Tranquility2 changed the title Improve test reliability Fix: Improve test reliability Mar 16, 2026
@Tranquility2 Tranquility2 changed the title Fix: Improve test reliability fix: Improve test reliability Mar 16, 2026
@Tranquility2
Copy link
Contributor Author

Tranquility2 commented Mar 16, 2026 •
edited
Loading

Looks like there is an issue with cassandra-driver (v3.29.3) in python 3.14
This blocks:

  1. linting
  2. test with python 3.14

@codecov
Copy link

codecov bot commented Mar 16, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.96%. Comparing base (44dd40b) to head (b9ac363).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #984      +/-   ##
==========================================
+ Coverage   78.94%   78.96%   +0.01%     
==========================================
  Files          14       14              
  Lines        1216     1217       +1     
  Branches      142      142              
==========================================
+ Hits          960      961       +1     
  Misses        214      214              
  Partials       42       42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Tranquility2
Tranquility2 commented Mar 16, 2026
View reviewed changes
@Tranquility2
Update core/tests/test_ryuk.py
b9ac363 
Remove extra import
@Tranquility2 Tranquility2 changed the title fix: Improve test reliability core: Improve test reliability Mar 16, 2026
@Tranquility2 Tranquility2 changed the title core: Improve test reliability fix: Improve test reliability Mar 16, 2026
@Tranquility2
Copy link
Contributor Author

Tranquility2 commented Mar 16, 2026

@alexanderankin mind taking a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Issue with testing ryuk under dind

1 participant

@Tranquility2